refactor(engine): improve payload processor tx iterator #21658
+18
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
Rjected,
mediocregopher and
yongkangc
as code owners
mattsse
force-pushed
the
mattsse/payload-processor-tx-iter-refactor
branch
from
97eef8f to
d3a0090
Compare
- Add transaction_count to ExecutionEnv, removing redundant parameter passing - Use rayon::spawn instead of spawn_blocking for parallel tx conversion - Remove transaction_count_hint parameter from spawn_caching_with and PrewarmCacheTask Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-019c157e-9967-76f6-bfeb-25f84b7b72b9
mattsse
force-pushed
the
mattsse/payload-processor-tx-iter-refactor
branch
from
d3a0090 to
9d28a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the transaction iterator spawning in payload processor for cleaner code.
Changes
Add
transaction_counttoExecutionEnv: The transaction count is now part of the execution environment metadata, removing redundant parameter passing throughspawn_caching_withandPrewarmCacheTask.Use
rayon::spawnfor parallel tx conversion: The parallel iterator work was usingspawn_blocking, but sincefor_each_withon aParallelIteratoralready runs on rayon's thread pool,rayon::spawnis more semantically correct and avoids unnecessary indirection.Testing
cargo check -p reth-engine-treepassescargo +nightly clippy -p reth-engine-tree --all-featurespasses